Date: Tue, 19 Aug 2008 08:23:12 +1000 (EST)
From: James Morris <jmorris@namei.org>
To: Cordelia <cordsam@linux.vnet.ibm.com>
cc: linux-kernel@vger.kernel.org, Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH] audit: Moved variable declaration to beginning of
 function
In-Reply-To: <48A9A73F.9060400@linux.vnet.ibm.com>
Message-ID: <alpine.LRH.1.10.0808190822350.24485@tundra.namei.org>
References: <48A9A73F.9060400@linux.vnet.ibm.com>
User-Agent: Alpine 1.10 (LRH 962 2008-03-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 39

On Mon, 18 Aug 2008, Cordelia wrote:

> got rid of compilation warning:
> ISO C90 forbids mixed declarations and code
> 
> Signed-off-by: Cordelia Sam <cordesam@gmail.com>
> ---
>  kernel/auditsc.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 972f8e6..59cedfb 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -243,10 +243,11 @@ static inline int open_arg(int flags, int mask)
>  
>  static int audit_match_perm(struct audit_context *ctx, int mask)
>  {
> +	unsigned n;
>  	if (unlikely(!ctx))
>  		return 0;
>  
> -	unsigned n = ctx->major;
> +	n = ctx->major;
>  	switch (audit_classify_syscall(ctx->arch, n)) {
>  	case 0:	/* native */
>  		if ((mask & AUDIT_PERM_WRITE) &&


Reviewed-by: James Morris <jmorris@namei.org>

-- 
James Morris
<jmorris@namei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/