Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754042AbYHSC6m (ORCPT ); Mon, 18 Aug 2008 22:58:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752585AbYHSC6d (ORCPT ); Mon, 18 Aug 2008 22:58:33 -0400 Received: from gate.crashing.org ([63.228.1.57]:42566 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbYHSC6d (ORCPT ); Mon, 18 Aug 2008 22:58:33 -0400 Subject: Re: ftrace introduces instability into kernel 2.6.27(-rc2,-rc3) From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Steven Rostedt Cc: Scott Wood , Eran Liberty , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Steven Rostedt , "Paul E. McKenney" In-Reply-To: <1219113549.8062.13.camel@pasglop> References: <48591941.4070408@extricom.com> <48A92E15.2080709@extricom.com> <48A9901B.1080900@redhat.com> <20080818154746.GA26835@Krystal> <48A9AFA7.8080508@freescale.com> <1219110814.8062.2.camel@pasglop> <1219113549.8062.13.camel@pasglop> Content-Type: text/plain Date: Tue, 19 Aug 2008 12:56:40 +1000 Message-Id: <1219114600.8062.15.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2352 Lines: 86 Ok, so i did a patch, but it doesn't fix the problem. So there's something else whacking on the stack frames. Still, here it is: powerpc/ftrace: Fix broken assembly for code replacement Instead, uses __get_user() and __put_user(). Signed-off-by: Benjamin Herrenschmidt --- Index: linux-work/arch/powerpc/kernel/ftrace.c =================================================================== --- linux-work.orig/arch/powerpc/kernel/ftrace.c 2008-08-19 12:45:49.000000000 +1000 +++ linux-work/arch/powerpc/kernel/ftrace.c 2008-08-19 12:52:51.000000000 +1000 @@ -16,7 +16,7 @@ #include #include - +#include static unsigned int ftrace_nop = 0x60000000; @@ -72,10 +72,9 @@ notrace int ftrace_modify_code(unsigned long ip, unsigned char *old_code, unsigned char *new_code) { - unsigned replaced; - unsigned old = *(unsigned *)old_code; - unsigned new = *(unsigned *)new_code; - int faulted = 0; + unsigned int old = *(unsigned int *)old_code; + unsigned int new = *(unsigned int *)new_code; + unsigned int instr; /* * Note: Due to modules and __init, code can @@ -85,32 +84,13 @@ ftrace_modify_code(unsigned long ip, uns * No real locking needed, this code is run through * kstop_machine. */ - asm volatile ( - "1: lwz %1, 0(%2)\n" - " cmpw %1, %5\n" - " bne 2f\n" - " stwu %3, 0(%2)\n" - "2:\n" - ".section .fixup, \"ax\"\n" - "3: li %0, 1\n" - " b 2b\n" - ".previous\n" - ".section __ex_table,\"a\"\n" - _ASM_ALIGN "\n" - _ASM_PTR "1b, 3b\n" - ".previous" - : "=r"(faulted), "=r"(replaced) - : "r"(ip), "r"(new), - "0"(faulted), "r"(old) - : "memory"); - - if (replaced != old && replaced != new) - faulted = 2; - - if (!faulted) - flush_icache_range(ip, ip + 8); - - return faulted; + if (__get_user(instr, (unsigned int __user *)ip)) + return 1; + if (instr != old && instr != new) + return 2; + WARN_ON_ONCE(__put_user(new, (unsigned int __user *)ip)); + flush_icache_range(ip, ip + 8); + return 0; } notrace int ftrace_update_ftrace_func(ftrace_func_t func) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/