Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753506AbYHSJc7 (ORCPT ); Tue, 19 Aug 2008 05:32:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752518AbYHSJcu (ORCPT ); Tue, 19 Aug 2008 05:32:50 -0400 Received: from casper.infradead.org ([85.118.1.10]:50745 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbYHSJcu (ORCPT ); Tue, 19 Aug 2008 05:32:50 -0400 Subject: Re: Backport hr-tick fix into .25/.26 From: Peter Zijlstra To: Ingo Molnar Cc: Justin Madru , lkml , Michal Januszewski , Antonino Daplas , Greg KH , Rafael Wysocki , Romano Giannetti , Adrian Bunk , Jeremy Nickurak In-Reply-To: <20080819092543.GD28713@elte.hu> References: <48A9BDC0.9070800@gawab.com> <20080819003110.GH9914@elte.hu> <1219127296.10800.357.camel@twins> <20080819092543.GD28713@elte.hu> Content-Type: text/plain Date: Tue, 19 Aug 2008 11:33:00 +0200 Message-Id: <1219138380.10800.376.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 35 On Tue, 2008-08-19 at 11:25 +0200, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > > On Tue, 2008-08-19 at 02:31 +0200, Ingo Molnar wrote: > > > * Justin Madru wrote: > > > > > > > This commit introduced the bug. > > > > commit 8f4d37ec073c17e2d4aa8851df5837d798606d6f > > > > sched: high-res preemption tick > > > > > > > And this one fixed it > > > > > > > > commit 31656519e132f6612584815f128c83976a9aaaef > > > > sched, x86: clean up hrtick implementation > > > > > > hm, the backport of 31656519 is a bit intrusive. > > > > > > find below is an (untested!) version of it - i havent even build-tested > > > it. Does it work for you? But this is Greg's call really. > > > > > > > It largely depends on all the new IPI stuff that went into 27 as well, > > so I'd be surprised if its easily backportable.. > > ah, i see. How about a simple patch then that disables hrtick [given > that it's now fixed .27 but the fix is too intrusive to backport]? Would > that be too risky for -stable? That's just flipping sched_feat(HRTICK) to 0 by default. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/