Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753256AbYHSKxQ (ORCPT ); Tue, 19 Aug 2008 06:53:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752126AbYHSKxA (ORCPT ); Tue, 19 Aug 2008 06:53:00 -0400 Received: from mtagate8.de.ibm.com ([195.212.29.157]:45316 "EHLO mtagate8.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbYHSKw7 (ORCPT ); Tue, 19 Aug 2008 06:52:59 -0400 In-Reply-To: <18602.18568.338552.482669@cargo.ozlabs.ibm.com> References: <200808051630.19619.fenkes@de.ibm.com> <18602.18568.338552.482669@cargo.ozlabs.ibm.com> To: Paul Mackerras Cc: Alexander Schmidt1 , Christoph Raisch , "David S. Miller" , Hoang-Nam Nguyen , LKML , "LinuxPPC-Dev" , Olaf Hering , Paul Mackerras , Stephen Rothwell , Stefan Roscher MIME-Version: 1.0 Subject: Re: [PATCH] ibmebus/of_platform: Move "name" sysfs attribute into generic OF devices X-KeepSent: D6515867:CFE29C04-C12574AA:003B8D55; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.0.1 HF105 April 10, 2008 From: Joachim Fenkes Message-ID: Date: Tue, 19 Aug 2008 12:52:07 +0200 X-MIMETrack: Serialize by Router on D12ML064/12/M/IBM(Release 8.0.1|February 07, 2008) at 19/08/2008 12:52:08, Serialize complete at 19/08/2008 12:52:08 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 21 Paul Mackerras wrote on 19.08.2008 06:14:00: > > Recent of_platform changes made of_bus_type_init() overwrite the bus type's > > .dev_attrs list, so move ibmebus' "name" attribute (which is needed by eHCA > > userspace support) into generic OF device code. Tested on POWER. > > Is this a bugfix that is needed for 2.6.27? Yes, definitely. The eHCA userspace driver relies on the name attribute to check for valid adapters (it checks that the name is "lhca"), so with the name attribute gone, eHCA userspace will cease to work. Regards, Joachim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/