Date: Tue, 19 Aug 2008 22:56:59 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       David Woodhouse <dwmw2@infradead.org>, Dave Jones <davej@redhat.com>,
       Sam Ravnborg <sam@ravnborg.org>, Greg KH <greg@kroah.com>,
       Randy Dunlap <randy.dunlap@oracle.com>,
       Kay Sievers <kay.sievers@vrfy.org>,
       Rodolfo Giometti <giometti@linux.it>
Subject: Re: [PATCH 08/10] PPS: serial clients support.
Message-ID: <20080819225659.3060a49f@lxorguk.ukuu.org.uk>
In-Reply-To: <1219182612-13814-9-git-send-email-giometti@linux.it>
References: <1219182612-13814-1-git-send-email-giometti@linux.it>
	<1219182612-13814-2-git-send-email-giometti@linux.it>
	<1219182612-13814-3-git-send-email-giometti@linux.it>
	<1219182612-13814-4-git-send-email-giometti@linux.it>
	<1219182612-13814-5-git-send-email-giometti@linux.it>
	<1219182612-13814-6-git-send-email-giometti@linux.it>
	<1219182612-13814-7-git-send-email-giometti@linux.it>
	<1219182612-13814-8-git-send-email-giometti@linux.it>
	<1219182612-13814-9-git-send-email-giometti@linux.it>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 605
Lines: 15

> +static void pps_tty_dcd_change(struct uart_port *port, unsigned int status,
> +				struct timespec *ts)
> +{
> +	int id = (int) port->info->port.tty->disc_data;

See you really do want to pass struct tty * upwards anyway 8)


Rest of this looks good. Maybe pps ldisc belongs in the n_tty file in the
end but again that can be twiddled with after the merge.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/