Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756135AbYHSWaj (ORCPT ); Tue, 19 Aug 2008 18:30:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752861AbYHSWa1 (ORCPT ); Tue, 19 Aug 2008 18:30:27 -0400 Received: from mms1.broadcom.com ([216.31.210.17]:2012 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752747AbYHSWa0 (ORCPT ); Tue, 19 Aug 2008 18:30:26 -0400 X-Server-Uuid: 02CED230-5797-4B57-9875-D5D2FEE4708A Date: Tue, 19 Aug 2008 15:30:25 -0700 From: "Matt Carlson" To: "Marc Haber" cc: "Michael Chan" , "David Miller" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Matthew Carlson" Subject: Re: 2.6.26/tg3 ping roundtrip times > 2000 ms on local network Message-ID: <20080819223025.GA11221@xw6200.broadcom.net> References: <20080819172019.GA5823@torres.zugschlus.de> <20080819.132040.188336475.davem@davemloft.net> <1219166962.13090.12.camel@HP1> <20080819221439.GA19106@torres.zugschlus.de> MIME-Version: 1.0 In-Reply-To: <20080819221439.GA19106@torres.zugschlus.de> User-Agent: Mutt/1.5.16 (2007-06-09) X-OriginalArrivalTime: 19 Aug 2008 22:30:16.0229 (UTC) FILETIME=[27527D50:01C9024B] X-WSS-ID: 64B596F04E0121017346-01-01 Content-Type: multipart/mixed; boundary=3V7upXqbjpZ4EhLz Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1982 Lines: 62 --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 7bit Can you try the attached patch? The patch reduces the delay back to what it should have been. If this helps, then it means you are being bitten by the same bug the upstream patch fixed. On Tue, Aug 19, 2008 at 03:14:39PM -0700, Marc Haber wrote: > On Tue, Aug 19, 2008 at 10:29:22AM -0700, Michael Chan wrote: > > It has been fixed a few days ago in the net-2.6 tree: > > > > tg3: Fix firmware event timeouts > > > > and it should be in Linus' tree very soon. This reminds us to send the > > same patch to -stable. > > Not having much clue about git, can you send me the patch to try > locally? > > I am not even sure to have a network issue here. > > Greetings > Marc > > -- > ----------------------------------------------------------------------------- > Marc Haber | "I don't trust Computers. They | Mailadresse im Header > Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834 > Nordisch by Nature | How to make an American Quilt | Fax: *49 3221 2323190 > --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=timeout.patch Content-Transfer-Encoding: 7bit diff -Nrup a/drivers/net/tg3.c b/drivers/net/tg3.c --- a/drivers/net/tg3.c 2008-08-06 09:19:01.000000000 -0700 +++ b/drivers/net/tg3.c 2008-08-19 15:26:50.000000000 -0700 @@ -1677,7 +1677,7 @@ static void tg3_wait_for_event_ack(struc int i; /* Wait for up to 2.5 milliseconds */ - for (i = 0; i < 250000; i++) { + for (i = 0; i < 250; i++) { if (!(tr32(GRC_RX_CPU_EVENT) & GRC_RX_CPU_DRIVER_EVENT)) break; udelay(10); --3V7upXqbjpZ4EhLz-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/