Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755228AbYHTLsO (ORCPT ); Wed, 20 Aug 2008 07:48:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752787AbYHTLr5 (ORCPT ); Wed, 20 Aug 2008 07:47:57 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:52590 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbYHTLr4 (ORCPT ); Wed, 20 Aug 2008 07:47:56 -0400 Date: Wed, 20 Aug 2008 20:46:07 +0900 From: KOSAKI Motohiro To: Christoph Lameter Subject: Re: No, really, stop trying to delete slab until you've finished making slub perform as well Cc: kosaki.motohiro@jp.fujitsu.com, Matthew Wilcox , Pekka Enberg , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mel Gorman , andi@firstfloor.org, Rik van Riel In-Reply-To: <48AACFDA.5090600@linux-foundation.org> References: <20080819192515.12C5.KOSAKI.MOTOHIRO@jp.fujitsu.com> <48AACFDA.5090600@linux-foundation.org> Message-Id: <20080820204005.12F3.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1756 Lines: 58 > KOSAKI Motohiro wrote: > > > IOW, My box didn't happend performance regression. > > but I think it isn't typical. > > Well that is typical for small NUMA system. Maybe this patch will fix it for > now? Large systems can be tuned by setting the ratio lower. > > > Subject: slub/NUMA: Disable remote node defragmentation by default > > Switch remote node defragmentation off by default. The current settings can > cause excessive node local allocations with hackbench. (Note that this feature > is not related to slab defragmentation). OK. I confirmed this patch works well. Tested-by: KOSAKI Motohiro > > Signed-off-by: Christoph Lameter > > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux-2.6/mm/slub.c > =================================================================== > --- linux-2.6.orig/mm/slub.c 2008-08-19 06:45:54.732348449 -0700 > +++ linux-2.6/mm/slub.c 2008-08-19 06:46:12.442348249 -0700 > @@ -2312,7 +2312,7 @@ static int kmem_cache_open(struct kmem_c > > s->refcount = 1; > #ifdef CONFIG_NUMA > - s->remote_node_defrag_ratio = 100; > + s->remote_node_defrag_ratio = 1000; > #endif > if (!init_kmem_cache_nodes(s, gfpflags & ~SLUB_DMA)) > goto error; > @@ -4058,7 +4058,7 @@ static ssize_t remote_node_defrag_ratio_ > if (err) > return err; > > - if (ratio < 100) > + if (ratio <= 100) > s->remote_node_defrag_ratio = ratio * 10; > > return length; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/