Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756072AbYHTMFQ (ORCPT ); Wed, 20 Aug 2008 08:05:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753803AbYHTME6 (ORCPT ); Wed, 20 Aug 2008 08:04:58 -0400 Received: from smtp-vbr15.xs4all.nl ([194.109.24.35]:1424 "EHLO smtp-vbr15.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753678AbYHTME5 (ORCPT ); Wed, 20 Aug 2008 08:04:57 -0400 Date: Wed, 20 Aug 2008 14:02:23 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@localhost.localdomain To: Andrew Morton cc: john stultz , Martin Ziegler , lkml , stable@kernel.org Subject: Re: [PATCH] fix adjtimex() freq return error In-Reply-To: <20080819204752.d9540f15.akpm@linux-foundation.org> Message-ID: References: <1219199346.6276.5.camel@localhost> <20080819204752.d9540f15.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 21 Hi, On Tue, 19 Aug 2008, Andrew Morton wrote: > On Tue, 19 Aug 2008 19:29:06 -0700 john stultz wrote: > > > Martin Ziegler reported a bug in adjtimex(), where odd positive > > frequencies are reduced by 1 while negative values are correct. To put this in perspective one should also know that 1 here means an error of 2^-16ppm or less than 0.02nsec. When I wrote this code, I noticed that the rounding isn't perfect, but OTOH the error is so small that it can't have any practical relevance. AFAIC the old code is fine as is. bye, Roman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/