Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756209AbYHTMkb (ORCPT ); Wed, 20 Aug 2008 08:40:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752760AbYHTMkW (ORCPT ); Wed, 20 Aug 2008 08:40:22 -0400 Received: from outbound-wa4.frontbridge.com ([216.32.181.16]:63605 "EHLO WA4EHSOBE005.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753343AbYHTMkU (ORCPT ); Wed, 20 Aug 2008 08:40:20 -0400 X-BigFish: VPS-34(zz1432R98dR936eQ62a3L1805Mzz10d3izzz32i6bh43j65h) X-Spam-TCS-SCL: 4:0 X-WSS-ID: 0K5WGIS-02-31X-01 Date: Wed, 20 Aug 2008 14:39:45 +0200 From: Robert Richter To: Arnd Bergmann CC: linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org, linux-kernel , oprofile-list@lists.sourceforge.net, Paul Mackerras , cel Subject: Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile Message-ID: <20080820123944.GQ13011@erda.amd.com> References: <1217620879.15667.145.camel@carll-linux-desktop> <18591.30474.127939.243247@cargo.ozlabs.ibm.com> <200808110918.57293.arnd@arndb.de> <200808110925.08485.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <200808110925.08485.arnd@arndb.de> User-Agent: Mutt/1.5.16 (2007-06-09) X-OriginalArrivalTime: 20 Aug 2008 12:40:05.0884 (UTC) FILETIME=[DF8663C0:01C902C1] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1756 Lines: 46 On 11.08.08 09:25:07, Arnd Bergmann wrote: > From: Carl Love > > The issue is the SPU code is not holding the kernel mutex lock while > adding samples to the kernel buffer. > > This patch creates per SPU buffers to hold the data. Data > is added to the buffers from in interrupt context. The data > is periodically pushed to the kernel buffer via a new Oprofile > function oprofile_put_buff(). The oprofile_put_buff() function > is called via a work queue enabling the funtion to acquire the > mutex lock. > > The existing user controls for adjusting the per CPU buffer > size is used to control the size of the per SPU buffers. > Similarly, overflows of the SPU buffers are reported by > incrementing the per CPU buffer stats. This eliminates the > need to have architecture specific controls for the per SPU > buffers which is not acceptable to the OProfile user tool > maintainer. > > The export of the oprofile add_event_entry() is removed as it > is no longer needed given this patch. > > Note, this patch has not addressed the issue of indexing arrays > by the spu number. This still needs to be fixed as the spu > numbering is not guarenteed to be 0 to max_num_spus-1. > > Signed-off-by: Carl Love > Signed-off-by: Maynard Johnson > Signed-off-by: Arnd Bergmann Acked-by: Robert Richter -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/