From: Johannes Weiner <hannes@saeurebad.de>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Section mismatch contig_page_data and bootmem_node_data
References: <20080820135551.74911cb3@lappy.seanm.ca>
Date: Wed, 20 Aug 2008 23:53:06 +0200
In-Reply-To: <20080820135551.74911cb3@lappy.seanm.ca> (Sean MacLennan's
	message of "Wed, 20 Aug 2008 13:55:51 -0400")
Message-ID: <87iqtv4am5.fsf@skyscraper.fehenstaub.lan>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1272
Lines: 39

Hi,

Sean MacLennan <smaclennan@pikatech.com> writes:

> If CONFIG_NEED_MULTIPLE_NODES is *not* set, then you get a section
> mismatch in reference from the variable contig_page_data to the
> variable __initdata bootmem_node_data.
>
> The simple solution is to just remove the __initdata from
> bootmem_node_data. We could also put an ifdef around the __initdata.
>
> Signed-off-by: Sean MacLennan <smaclennan@pikatech.com>
> ---
> diff --git a/mm/bootmem.c b/mm/bootmem.c
> index e023c68..a968ae2 100644
> --- a/mm/bootmem.c
> +++ b/mm/bootmem.c
> @@ -31,7 +31,7 @@ unsigned long max_pfn;
>  unsigned long saved_max_pfn;
>  #endif
>  
> -bootmem_data_t bootmem_node_data[MAX_NUMNODES] __initdata;
> +bootmem_data_t bootmem_node_data[MAX_NUMNODES];

It is totally valid to be init data as it does not get referenced after
bootup and should therefor be freed.

The statically defined pointer from contig_page_data is the problem and
the fix should be on this end rather than worsening code to suppress a
warning.

NAK,

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/