Message-ID: <48ACA785.6030607@citrix.com>
Date: Thu, 21 Aug 2008 00:23:49 +0100
From: Alex Nixon <alex.nixon@citrix.com>
User-Agent: Thunderbird 2.0.0.16 (Windows/20080708)
MIME-Version: 1.0
To: Yinghai Lu <yhlu.kernel@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>,
       Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] X86: Change the default value of nr_irqs from 32 to NR_IRQs
References: <48AAFAE4.7070409@citrix.com>	 <86802c440808191044h74871ba1u62330dae18599436@mail.gmail.com>	 <0E902970173AF84089673FA54B7FE78A2CA11D@lonpexch01.citrite.net>	 <86802c440808191124v39ce2aa9rb548d3bdd75ca25c@mail.gmail.com>	 <48AB11A3.4060102@citrix.com>	 <86802c440808191200u364ffd86h49af661e58d20ea3@mail.gmail.com>	 <48AB241A.4030706@citrix.com> <86802c440808191352g75c99737kcb8c9c20d59c8f7b@mail.gmail.com> <48AB551D.6010708@citrix.com>
In-Reply-To: <48AB551D.6010708@citrix.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1375
Lines: 38

Alex Nixon wrote:
> Yinghai Lu wrote:
>> when !CONFIG_HAVE_SPARSE_IRQ, with dyn_array, could allocate irq_desc
>> and etc as less as possible.
>> when CONFIG_HAVE_SPARESE_IRQ, no actually meaning for nr_irqs.
>>
>> YH
> 
> So I believe the only case this affects is !CONFIG_HAVE_SPARSE_IRQ
> 
> The worry is that with CONFIG_HAVE_DYN_ARRAY we may waste memory by 
> pre-allocating more irq_descs than may be necessary (NR_IRQs vs 32)?
> 
> With !CONFIG_HAVE_DYN_ARRAY however, a static array of size NR_IRQS is 
> allocated instead - so doesn't defaulting nr_irqs back to NR_IRQS just 
> revert to the old behaviour (with the exception of the irq_descs being 
> allocated in pre_alloc_dyn_array instead)?
> 
> - Alex
> 

Sorry to pester you Yinghai, but I'd like to get a patch for this out 
one way or another as Xen is _completely_ unusable with 5 or more VCPUs.

Can you explain more clearly what the problem with the patch is?

I have a different patch set which solves the problem by adding in a pv 
hook for probe_nr_irqs, but it's by far less clean.

Or alternatively, we could revert your patch b2e5f326bb

Cheers,
- Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/