Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756875AbYHUGUl (ORCPT ); Thu, 21 Aug 2008 02:20:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753432AbYHUGUc (ORCPT ); Thu, 21 Aug 2008 02:20:32 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:43510 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753336AbYHUGUc (ORCPT ); Thu, 21 Aug 2008 02:20:32 -0400 Date: Thu, 21 Aug 2008 08:15:12 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Ray Lee , Nick Piggin , adobriyan@gmail.com, "Zhang, Yanmin" , Dhaval Giani , LKML , Srivatsa Vaddagiri , Aneesh Kumar KV , Balbir Singh , Chris Friesen Subject: Re: VolanoMark regression with 2.6.27-rc1 Message-ID: <20080821061512.GB14572@elte.hu> References: <1912217169.25608.228.camel@ymzhang> <2c0942db0808200929r640b3a1cj33efc56cfd6db9b3@mail.gmail.com> <1219252901.8651.63.camel@twins> <200808210355.55597.nickpiggin@yahoo.com.au> <2c0942db0808201115v3025e5f6r6c882783fa9e29f3@mail.gmail.com> <1219264236.8651.76.camel@twins> <1219265798.8651.84.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1219265798.8651.84.camel@twins> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 23 * Peter Zijlstra wrote: > Ok, people pointed out I got my promotion rules mixed up, I casted the > result of the division to signed, instead of ending up with a signed > division. > > #define avg(x, y) ({ \ > typeof(x) _avg1 = (x); \ > typeof(y) _avg2 = (y); \ > (void) (&_avg1 == &_avg2); \ > (typeof(x))(_avg1 + ((long long)_avg2 - _avg1)/2); }) ok, could you please just send a patch that is local to sched.c and then we can let this kernel.h change play out independently? There's too many iterations of this and it's better to decouple the two. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/