Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758263AbYHUHdW (ORCPT ); Thu, 21 Aug 2008 03:33:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755585AbYHUHdI (ORCPT ); Thu, 21 Aug 2008 03:33:08 -0400 Received: from 81-7-68-229.static.zebra.lt ([81.7.68.229]:33819 "EHLO teltonika.lt" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755037AbYHUHdH (ORCPT ); Thu, 21 Aug 2008 03:33:07 -0400 Message-ID: <48AD1A27.2090400@teltonika.lt> Date: Thu, 21 Aug 2008 10:32:55 +0300 From: Paulius Zaleckas User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 CC: jaredeh@gmail.com, =?ISO-8859-1?Q?J=F6rn_Engel?= , linux-mtd , Linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org, tim.bird@AM.SONY.COM Subject: Re: [PATCH 01/10] AXFS: exporting xip_file_fault() for use with AXFS References: <48AD00D5.5010904@gmail.com> <48AD1860.4040001@teltonika.lt> In-Reply-To: <48AD1860.4040001@teltonika.lt> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2110 Lines: 63 Paulius Zaleckas wrote: > Jared Hulbert wrote: >> We'll need this for AXFS. The equivalent function in filemap.c is exported. >> >> Signed-off-by: Jared Hulbert >> --- >> include/linux/mm.h | 4 ++++ >> mm/filemap_xip.c | 3 ++- >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 72a15dc..2be5c22 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -161,6 +161,10 @@ struct vm_fault { >> */ >> }; >> >> +#ifdef CONFIG_FS_XIP >> +extern int xip_file_fault(struct vm_area_struct *vma, struct vm_fault *vmf); >> +#endif >> + > > No need for #ifdef here as this function is compiled and exported in .c > regardless of CONFIG_FS_XIP Sorry I am wrong... Have to get more sleep :) >> /* >> * These are the virtual MM functions - opening of an area, closing and >> * unmapping it (needed to keep files on disk up-to-date etc), pointer >> diff --git a/mm/filemap_xip.c b/mm/filemap_xip.c >> index 380ab40..ab2f174 100644 >> --- a/mm/filemap_xip.c >> +++ b/mm/filemap_xip.c >> @@ -206,7 +206,7 @@ __xip_unmap (struct address_space * mapping, >> * >> * This function is derived from filemap_fault, but used for execute in place >> */ >> -static int xip_file_fault(struct vm_area_struct *vma, struct vm_fault *vmf) >> +int xip_file_fault(struct vm_area_struct *vma, struct vm_fault *vmf) >> { >> struct file *file = vma->vm_file; >> struct address_space *mapping = file->f_mapping; >> @@ -262,6 +262,7 @@ found: >> return 0; >> } >> } >> +EXPORT_SYMBOL_GPL(xip_file_fault); >> >> static struct vm_operations_struct xip_file_vm_ops = { >> .fault = xip_file_fault, >> > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/