Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758622AbYHUKfL (ORCPT ); Thu, 21 Aug 2008 06:35:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752837AbYHUKe6 (ORCPT ); Thu, 21 Aug 2008 06:34:58 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:40135 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416AbYHUKe5 (ORCPT ); Thu, 21 Aug 2008 06:34:57 -0400 Date: Thu, 21 Aug 2008 12:34:44 +0200 From: Ingo Molnar To: Marcin Slusarz Cc: LKML , Jack Steiner Subject: Re: [PATCH] x86: silence section mismatch warning - uv_cpu_init Message-ID: <20080821103444.GE19452@elte.hu> References: <1219259268-5868-2-git-send-email-marcin.slusarz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1219259268-5868-2-git-send-email-marcin.slusarz@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 25 * Marcin Slusarz wrote: > WARNING: vmlinux.o(.cpuinit.text+0x3cc4): Section mismatch in reference from the function uv_cpu_init() to the function .init.text:uv_system_init() > The function __cpuinit uv_cpu_init() references > a function __init uv_system_init(). > If uv_system_init is only used by uv_cpu_init then > annotate uv_system_init with a matching annotation. > > uv_system_init was ment to be called only once, so make explicit by > creating properly-named function and annotate it as __ref. > > Old code relied on uv_node_to_blade being initialized to 0, but it'a > not initialized from anywhere and it's not static either. this needs a proper fix as the patch is too ugly. If something should be called only once then it has to go into a codepath that will only initialize it once. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/