Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758762AbYHUKp0 (ORCPT ); Thu, 21 Aug 2008 06:45:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754328AbYHUKpJ (ORCPT ); Thu, 21 Aug 2008 06:45:09 -0400 Received: from mx1.redhat.com ([66.187.233.31]:40046 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755885AbYHUKpI (ORCPT ); Thu, 21 Aug 2008 06:45:08 -0400 Message-ID: <48AD46C4.30207@redhat.com> Date: Thu, 21 Aug 2008 06:43:16 -0400 From: Ric Wheeler Reply-To: rwheeler@redhat.com Organization: Red Hat User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Jens Axboe CC: Eric Sandeen , Milan Broz , Linux Kernel Mailing List , linux-fsdevel , "MASON,CHRISTOPHER" Subject: Re: Mount ext3 with barrier=1 doesn't send real barrier bio? References: <48A5F5C6.2090204@redhat.com> <48ACAADD.2010104@sandeen.net> <20080821052604.GM20055@kernel.dk> In-Reply-To: <20080821052604.GM20055@kernel.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 33 Jens Axboe wrote: > On Wed, Aug 20 2008, Eric Sandeen wrote: > >> Milan Broz wrote: >> >>> Hi, >>> >>> I run some barrier tests over device-mapper (which currently doesn't >>> support barrier bio at all) and even if I set barrier=1 in ext3 mount, >>> there is never any bio with barrier flag... (in 2.6.27-rc) >>> >>> How is the barrier=1 flag supposed to work in ext3 (JBD) now? >>> >> Milan, you're right. Ric saw this same strange behavior when doing some >> benchmarking with and without barriers; Chris noticed the change in >> submit_bh; I was about to write up a similar patch to what you've sent >> already. Jens, does Milan's fix look good to you? >> > > Yep looks good, thanks a lot Milan! I'll send in the patch, unless I'm > badly mistaken we need it for 2.6.26-stable as well. > > I think we definitely need it there as well, thanks! Ric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/