Date: Thu, 21 Aug 2008 13:49:52 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Shaohua Li <shaohua.li@intel.com>, lkml <linux-kernel@vger.kernel.org>,
       Dave Airlie <airlied@gmail.com>, Arjan van de Ven <arjan@infradead.org>
Subject: Re: [3/4] add agp_generic_destroy_pages()
Message-ID: <20080821114952.GE30667@elte.hu>
References: <1219286777.18007.41.camel@sli10-desk.sh.intel.com> <20080820200807.324aa671.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080820200807.324aa671.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1098
Lines: 37


* Andrew Morton <akpm@linux-foundation.org> wrote:

> stylistic nit:
> 
> > +
> > +			for (i = 0; i < curr->page_count; i++) {
> > +				curr->memory[i] = (unsigned long)gart_to_virt(
> > +					curr->memory[i]);
> > +				curr->bridge->driver->agp_destroy_page(
> > +					(void *)curr->memory[i],
> > +					AGP_PAGE_DESTROY_UNMAP);
> > +			}
> > +			for (i = 0; i < curr->page_count; i++) {
> > +				curr->bridge->driver->agp_destroy_page(
> > +					(void *)curr->memory[i],
> > +					AGP_PAGE_DESTROY_FREE);
> > +			}
> 
> Make the above code a standalone function and call it here.
> 
> Then convert all drivers over so their .agp_destroy_pages points at
> that new function.
> 
> Then remove the `if'.

good point.

[ Shaohua, when you fix this, please do it as a delta patch against your 
  current patchset (or against tip/master). Thanks. ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/