Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756642AbYHUMok (ORCPT ); Thu, 21 Aug 2008 08:44:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756187AbYHUMoV (ORCPT ); Thu, 21 Aug 2008 08:44:21 -0400 Received: from vpn.id2.novell.com ([195.33.99.129]:35778 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755919AbYHUMoU convert rfc822-to-8bit (ORCPT ); Thu, 21 Aug 2008 08:44:20 -0400 Message-Id: <48AD7F80.76E4.0078.0@novell.com> X-Mailer: Novell GroupWise Internet Agent 7.0.3 Date: Thu, 21 Aug 2008 13:45:20 +0100 From: "Jan Beulich" To: , "Ingo Molnar" Cc: Subject: patch "x86: MOVE PCI IO ECS code to x86/pci" breaks CPU hotplug Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 17 Converting __cpuinit functions called out of init_amd() (and similar others) to __init (and making them subject of xxx_initcall() handling isn't valid, as they would no longer be called for hot plugged CPUs. Further, since it's likely that in virtualized environments the MSR write would at best be ignored, I'd also recommend using the fault-safe accessors here *and* check that the bit actually got set before setting PCI_HAS_IO_ECS (one would obviously have to BUG() when hot-plugged CPUs fail to set the bit when those available at boot successfully did so). Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/