Date: Thu, 21 Aug 2008 23:16:50 +0900
To: mingo@elte.hu
Cc: joerg.roedel@amd.com, fujita.tomonori@lab.ntt.co.jp,
       jbarnes@virtuousgeek.org, mingo@redhat.com, tglx@linutronix.de,
       hpa@zytor.com, linux-kernel@vger.kernel.org,
       iommu@lists.linux-foundation.org, muli@il.ibm.com
Subject: Re: [PATCH 0/8] x86 dma_*_coherent rework patchset v2
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
In-Reply-To: <20080820094612.GA28492@elte.hu>
References: <1219156366-32498-1-git-send-email-joerg.roedel@amd.com>
	<20080820094612.GA28492@elte.hu>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20080821231230V.fujita.tomonori@lab.ntt.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1771
Lines: 40

On Wed, 20 Aug 2008 11:46:12 +0200
Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Joerg Roedel <joerg.roedel@amd.com> wrote:
> 
> > Hi,
> > 
> > this patchset reworks the dma_*_coherent functions in the DMA layer 
> > for the x86 architecture. The patch series extends the existing DMA 
> > backends with missing *coherent callbacks and simplifies the generic 
> > function to basically only call the registered backend. This allows 
> > future optimizations in hardware specific IOMMU implementations. The 
> > code ist tested on AMD64 with AMD IOMMU, GART, SWIOTLB and NOMMU as 
> > well as on my old 486 box. Muli tested the Calgary specific patch.
> > 
> > Joerg
> > 
> > Changes since v1:
> > 
> > - fixed wrong logic in the pci-nommu alloc_coherent code
> > - moved dma_*_coherent to include/asm-x86/dma-mapping.h
> > 
> > git diff --stat tip/master.. :
> > 
> >  arch/x86/kernel/amd_iommu.c      |    2 -
> >  arch/x86/kernel/pci-calgary_64.c |   14 ++++
> >  arch/x86/kernel/pci-dma.c        |  146 +-------------------------------------
> >  arch/x86/kernel/pci-gart_64.c    |   35 +++++++++-
> >  arch/x86/kernel/pci-nommu.c      |   62 ++++++++++++++++
> >  include/asm-x86/dma-mapping.h    |   47 ++++++++++---
> >  6 files changed, 149 insertions(+), 157 deletions(-)
> 
> applied to tip/x86/iommu - thanks Joerg!
> 
> Jesse, Fujita-san, do these changes look fine to you?

As I wrote in another mail, GART should return zeroed memory (keeping
the current behavior is better). Except for it, the patchset looks
fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/