Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756915AbYHURgA (ORCPT ); Thu, 21 Aug 2008 13:36:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752339AbYHURfw (ORCPT ); Thu, 21 Aug 2008 13:35:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:34160 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbYHURfw (ORCPT ); Thu, 21 Aug 2008 13:35:52 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Ingo Oeser , Kay Sievers , Greg Kroah-Hartman Subject: [PATCH 01/15] kobject: Replace ALL occurrences of '/' with '!' instead of only the first one. Date: Thu, 21 Aug 2008 10:32:49 -0700 Message-Id: <1219339983-9634-1-git-send-email-gregkh@suse.de> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <20080821173036.GB7974@suse.de> References: <20080821173036.GB7974@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 37 From: Ingo Oeser A recent patch from Kay Sievers replaced the first occurrence of '/' with '!' as needed for block devices. Now do some cheap defensive coding and replace all of them to avoid future issues in this area. Signed-off-by: Ingo Oeser Cc: Kay Sievers Signed-off-by: Greg Kroah-Hartman --- lib/kobject.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index bd732ff..fbf0ae2 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -223,8 +223,7 @@ static int kobject_set_name_vargs(struct kobject *kobj, const char *fmt, return -ENOMEM; /* ewww... some of these buggers have '/' in the name ... */ - s = strchr(kobj->name, '/'); - if (s) + while ((s = strchr(kobj->name, '/'))) s[0] = '!'; kfree(old_name); -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/