DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=RqIbheGASmcvmg8qkvo72fZOZJJjMZHuwUCnokz15HdcqeeKjEQZS35OH/cM/0HGgpN0NMQ9wrI5uhcRUwna35fl3zc6HJRzXgIgNWjKUVusShyDM/Fmh4tmksE0atrhaPypfJK+pAzObRuWbNAKnom5dYCbdht2ylXT/XhU0q8=  ;
From: David Brownell <david-b@pacbell.net>
To: Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 06/15] driver model: anti-oopsing medicine
Date: Thu, 21 Aug 2008 11:24:22 -0700
User-Agent: KMail/1.9.9
Cc: linux-kernel@vger.kernel.org
References: <20080821173036.GB7974@suse.de> <1219339983-9634-6-git-send-email-gregkh@suse.de>
In-Reply-To: <1219339983-9634-6-git-send-email-gregkh@suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200808211124.22485.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 745
Lines: 22

On Thursday 21 August 2008, Greg Kroah-Hartman wrote:
> +???????if (!class->p) {
> +???????????????WARN(1, "%s called for class '%s' before it was initialized",
> +??????????????? ? ? __func__, class->name);
> +???????????????return -EINVAL;
> +???????}

Or -- for future reference -- using WARN() with non-constant
initial parameter:

	if (WARN(!class-p, "%s called ...\n" ...))
		return -EINVAL;

Some of those macros now have return values, supportin C code
that looks a bit more compact.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/