Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761377AbYHUXHh (ORCPT ); Thu, 21 Aug 2008 19:07:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759669AbYHUXH3 (ORCPT ); Thu, 21 Aug 2008 19:07:29 -0400 Received: from outbound-mail-125.bluehost.com ([67.222.38.25]:53030 "HELO outbound-mail-125.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1759258AbYHUXH2 (ORCPT ); Thu, 21 Aug 2008 19:07:28 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id:X-Identified-User; b=Pt838IdqGD1aA/nGyyHgjeJisTdsk1jzarvbJCX47J2umRRFFwDOw3oqW8B2rBEo76D2WkkEqkVu8cVRAJoKFJqhJyde4usaa5r5UCJ5a0m00WThP+xRzZs1CzfCvcDu; From: Jesse Barnes To: "Eric W. Biederman" Subject: Re: [PATCH] pci: change msi-x vector to 32bit Date: Thu, 21 Aug 2008 16:07:05 -0700 User-Agent: KMail/1.9.9 Cc: Yinghai Lu , James Bottomley , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , linux-kernel@vger.kernel.org, Andrew Vasquez References: <1218854205-2375-1-git-send-email-yhlu.kernel@gmail.com> <200808211333.00887.jbarnes@virtuousgeek.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808211607.05811.jbarnes@virtuousgeek.org> X-Identified-User: {642:box128.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 75.111.27.49 authed with jbarnes@virtuousgeek.org} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2395 Lines: 61 On Thursday, August 21, 2008 1:47 pm Eric W. Biederman wrote: > Jesse Barnes writes: > > On Friday, August 15, 2008 7:36 pm Yinghai Lu wrote: > >> we are using 28bit pci (bus/dev/fn + 12 bits) as irq number, so the > >> cache for irq number should be 32 bit too. > >> > >> Signed-off-by: Yinghai Lu > >> Cc: Andrew Vasquez > >> > >> --- > >> drivers/scsi/qla2xxx/qla_def.h | 2 +- > >> include/linux/pci.h | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> Index: linux-2.6/drivers/scsi/qla2xxx/qla_def.h > >> =================================================================== > >> --- linux-2.6.orig/drivers/scsi/qla2xxx/qla_def.h > >> +++ linux-2.6/drivers/scsi/qla2xxx/qla_def.h > >> @@ -2109,7 +2109,7 @@ struct scsi_qla_host; > >> > >> struct qla_msix_entry { > >> int have_irq; > >> - uint16_t msix_vector; > >> + uint32_t msix_vector; > >> uint16_t msix_entry; > >> }; > >> > >> Index: linux-2.6/include/linux/pci.h > >> =================================================================== > >> --- linux-2.6.orig/include/linux/pci.h > >> +++ linux-2.6/include/linux/pci.h > >> @@ -730,7 +730,7 @@ enum pci_dma_burst_strategy { > >> }; > >> > >> struct msix_entry { > >> - u16 vector; /* kernel uses to write allocated vector */ > >> + u32 vector; /* kernel uses to write allocated vector */ > >> u16 entry; /* driver uses to specify entry, OS writes */ > >> }; > > > > I see a lot of smoke about this, but not a clear consensus. It sounds > > like no one objects to making the MSI vector field 32 bits, but there > > were a lot of concerns about IRQ vector naming/numbering in general? And > > I assume this particular patch isn't 2.6.27 material... > > There is no need for this particular patch in 2.6.27. > It is a trivial bug fix so it can go in whenever. > > Mostly this is a discussion about code that should land in the 2.6.28 > timeframe assuming all is well. Ok, thanks Eric. I'll queue it up for linux-next after the next 2.6.27 pull. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/