Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760545AbYHVCc0 (ORCPT ); Thu, 21 Aug 2008 22:32:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753216AbYHVCcS (ORCPT ); Thu, 21 Aug 2008 22:32:18 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:56096 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbYHVCcR (ORCPT ); Thu, 21 Aug 2008 22:32:17 -0400 Message-ID: <48AE24F5.3010309@jp.fujitsu.com> Date: Fri, 22 Aug 2008 11:31:17 +0900 From: Kenji Kaneshige User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Greg KH CC: Linux Kernel Mailing List Subject: Re: [PATCH] Fix possible kobject reference counter leak in kobject_rename() References: <48AD4414.6080604@jp.fujitsu.com> <20080821155845.GA2424@suse.de> In-Reply-To: <20080821155845.GA2424@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 53 Greg KH wrote: > On Thu, Aug 21, 2008 at 07:31:48PM +0900, Kenji Kaneshige wrote: >> Hi, >> >> I found a possible kobject reference counter leak problem in >> kobject_rename(). The following patch will fix it. >> >> Thanks, >> Kenji Kaneshige >> >> >> Fix possible kobject reference counter leak in kobject_rename(). >> >> If kobject_rename() failed because of name collision, we must call >> kobject_put() for specified kobject before return. >> >> Signed-off-by: Kenji Kaneshige >> >> --- >> lib/kobject.c | 1 + >> 1 file changed, 1 insertion(+) >> >> Index: linux-2.6.27-rc4/lib/kobject.c >> =================================================================== >> --- linux-2.6.27-rc4.orig/lib/kobject.c >> +++ linux-2.6.27-rc4/lib/kobject.c >> @@ -411,6 +411,7 @@ int kobject_rename(struct kobject *kobj, >> "to '%s' as '%s' is already in existence.\n", >> kobject_name(kobj), new_name, new_name); >> kobject_put(temp_kobj); >> + kobject_put(kobj); >> return -EINVAL; >> } >> } > > Thanks, but this is already fixed up with a patch from Eric in my tree > in a different way. > > greg k-h > > Ah, I see. I didn't notice that. Thank you for the information. Thanks, Kenji Kaneshige -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/