Date: Fri, 22 Aug 2008 09:58:21 +0200
From: Jens Axboe <jens.axboe@oracle.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Eric Sandeen <sandeen@sandeen.net>, Milan Broz <mbroz@redhat.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       linux-fsdevel <linux-fsdevel@vger.kernel.org>,
       Ric Wheeler <rwheeler@redhat.com>,
       "MASON,CHRISTOPHER" <CHRIS.MASON@oracle.com>
Subject: Re: Mount ext3 with barrier=1 doesn't send real barrier bio?
Message-ID: <20080822075821.GS20055@kernel.dk>
References: <48A5F5C6.2090204@redhat.com> <48ACAADD.2010104@sandeen.net> <874p5eqa6h.fsf@devron.myhome.or.jp> <20080822063823.GR20055@kernel.dk> <87pro1xzkd.fsf@devron.myhome.or.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pro1xzkd.fsf@devron.myhome.or.jp>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1116
Lines: 34

On Fri, Aug 22 2008, OGAWA Hirofumi wrote:
> Jens Axboe <jens.axboe@oracle.com> writes:
> 
> >> This should be ((rw & RW_MASK) == WRITE) too?  Anyway, this seems change
> >> behavior of submit_bh(WRITE_BARRIER) (maybe reiserfs only), it wouldn't
> >> be your intent...
> >
> > Yes, I believe the simpler and more correct fix is:
> >
> > diff --git a/fs/buffer.c b/fs/buffer.c
> > index 38653e3..16b2263 100644
> > --- a/fs/buffer.c
> > +++ b/fs/buffer.c
> > @@ -2926,14 +2926,13 @@ int submit_bh(int rw, struct buffer_head * bh)
> >  	BUG_ON(!buffer_mapped(bh));
> >  	BUG_ON(!bh->b_end_io);
> >  
> > -	if (buffer_ordered(bh) && (rw == WRITE))
> > +	if (buffer_ordered(bh) && (rw & WRITE))
> >  		rw = WRITE_BARRIER;
> 
> I see. But, umm..., this means WRITE_SYNC with barrier was deprecated?
> Or typo?

It was supposed to read rw |= WRITE_BARRIER :-)

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/