Message-ID: <48AF10BE.9050100@opengridcomputing.com>
Date: Fri, 22 Aug 2008 14:17:18 -0500
From: Steve Wise <swise@opengridcomputing.com>
User-Agent: Thunderbird 2.0.0.16 (X11/20080724)
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: Karen Xie <kxie@chelsio.com>, netdev@vger.kernel.org,
       open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
       linux-kernel@vger.kernel.org, jgarzik@pobox.com, davem@davemloft.net,
       michaelc@cs.wisc.edu, rdreier@cisco.com, daisyc@us.ibm.com,
       wenxiong@us.ibm.com, bhua@us.ibm.com, divy@chelsio.com, dm@chelsio.com,
       leedom@chelsio.com
Subject: Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI
References: <200808221838.m7MIcW6a004400@localhost.localdomain> <20080822120851.c45a90f2.akpm@linux-foundation.org>
In-Reply-To: <20080822120851.c45a90f2.akpm@linux-foundation.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1009
Lines: 38

Andrew Morton wrote:
>> +	unsigned long octet;
>> +	const char *parse = buf;
>> +	char *endp;
>> +	int i;
>> +
>> +	for (i = 1; i <= 4; i++) {
>> +		octet = simple_strtoul(parse, &endp, 10);
>> +		if (endp == buf || octet > 255 ||
>> +		    (i < 4 && *endp != '.') ||
>> +		    (i == 4 && *endp != '\0' && *endp != '\n'))
>> +			return -EINVAL;
>> +		a = (a << 8) | octet;
>> +		parse = endp+1;
>> +	}
>> +	pi->iscsi_ipaddr = htonl(a);
>> +	return endp-buf;
>> +}
>>     
>
> This appears to be taking a dotted quad ipv4 address in ascii form,
> turning it into a u32 while performing checking?
>
> Surely we have a library function somewhere in networking which does
> this?  If not, I'd suggest writing one. 
>
>   

try in_aton() from include/linux/inet.h.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/