Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758629AbYHVUzt (ORCPT ); Fri, 22 Aug 2008 16:55:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752968AbYHVUzO (ORCPT ); Fri, 22 Aug 2008 16:55:14 -0400 Received: from yw-out-2324.google.com ([74.125.46.28]:38114 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbYHVUzM (ORCPT ); Fri, 22 Aug 2008 16:55:12 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=WzJY+IvrW6Jqyyn51Q++P9QcAG3Vk7P5OriFRt/MP7lAWTQM9SG0m0clVzA/JCDi7w L9CFpPskScXd9VvePrMkvC+JznOU08ZHIXVrJRdK1v3JQhHMwnAcoEITJHE2STk84QBI P7kHlQYwdPcT0he3vxiPaVDvJsPiz4+O247xQ= Date: Fri, 22 Aug 2008 22:54:19 +0200 From: Marcin Slusarz To: "Rafael J. Wysocki" Cc: Pavel Machek , Ingo Molnar , Steven Rostedt , Nigel Cunningham , LKML , Andrew Morton , Linus Torvalds Subject: Re: ftraced and suspend to ram Message-ID: <20080822205415.GA5452@joi> References: <20080822072343.GA24173@atrey.karlin.mff.cuni.cz> <20080822103533.GA5425@joi> <200808221839.35640.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200808221839.35640.rjw@sisk.pl> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2105 Lines: 54 On Fri, Aug 22, 2008 at 06:39:34PM +0200, Rafael J. Wysocki wrote: > On Friday, 22 of August 2008, Marcin Slusarz wrote: > > On Fri, Aug 22, 2008 at 09:23:43AM +0200, Pavel Machek wrote: > > > > > > > > * Rafael J. Wysocki wrote: > > > > > > > > > > > The code in question is the ftraced() function in > > > > > > > kernel/trace/ftrace.c > > > > > > > > > > > > Thanks, I'll have a look in a while. > > > > > > > > > > Can you try the appended patch, please? > > > > > > > > makes sense - i've applied it to tip/tracing/urgent, see the tidied up > > > > commit below. > > > > > > > > It should be no big issue not being able to trace across suspend+resume > > > > - and that restriction will go away with Steve's build-time based mcount > > > > patching mechanism in v2.6.28. > > > > > > Patch looks okay to me, but I'm not sure if another issue is not > > > hiding under it. Did anyone actually test ftrace + suspend after > > > applying this? > > > > I just tested this patch - it didn't help ;( > > > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > > index 49f4c3f..02e41b2 100644 > > --- a/kernel/trace/ftrace.c > > +++ b/kernel/trace/ftrace.c > > @@ -27,6 +27,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > This is needed to fix compilation, sorry for the omission. > > Still, did you test ftrace + suspend with the original patch and your fix > applied and if you did, then what happend? Suspend works fine. When I hit power button I see some informations from video card (nvidia), then screen goes black and monitor says "no signal" and then I see the same informations from video card, then BIOS and GRUB. When everything works fine, X comes back after first infos from video card. Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/