Date: Fri, 22 Aug 2008 19:14:10 -0700
From: Greg KH <gregkh@suse.de>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <syrjala@sci.fi>,
       linux-kernel@vger.kernel.org, Ingo Oeser <ioe-lkml@rameria.de>,
       Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH 01/15] kobject: Replace ALL occurrences of '/' with '!'
	instead of only the first one.
Message-ID: <20080823021410.GB21403@suse.de>
References: <20080821173036.GB7974@suse.de> <1219339983-9634-1-git-send-email-gregkh@suse.de> <20080822124153.GF16680@sci.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20080822124153.GF16680@sci.fi>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1528
Lines: 46

On Fri, Aug 22, 2008 at 03:41:53PM +0300, Ville Syrj?l? wrote:
> On Thu, Aug 21, 2008 at 10:32:49AM -0700, Greg Kroah-Hartman wrote:
> > From: Ingo Oeser <ioe-lkml@rameria.de>
> > 
> > A recent patch from Kay Sievers <kay.sievers@vrfy.org>
> > replaced the first occurrence of '/' with '!' as needed for block devices.
> > 
> > Now do some cheap defensive coding and replace all of them to avoid future
> > issues in this area.
> > 
> > Signed-off-by: Ingo Oeser <ioe-lkml@rameria.de>
> > Cc: Kay Sievers <kay.sievers@vrfy.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > ---
> >  lib/kobject.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/kobject.c b/lib/kobject.c
> > index bd732ff..fbf0ae2 100644
> > --- a/lib/kobject.c
> > +++ b/lib/kobject.c
> > @@ -223,8 +223,7 @@ static int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
> >  		return -ENOMEM;
> >  
> >  	/* ewww... some of these buggers have '/' in the name ... */
> > -	s = strchr(kobj->name, '/');
> > -	if (s)
> > +	while ((s = strchr(kobj->name, '/')))
> >  		s[0] = '!';
> 
> That's somewhat inefficient. How about this?
> 
> s = kobj->name;
> while ((s = strchr(s, '/')))
> 	*s++ = '!';

Sure, but does it really matter?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/