Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922AbYHWKCg (ORCPT ); Sat, 23 Aug 2008 06:02:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752536AbYHWKC1 (ORCPT ); Sat, 23 Aug 2008 06:02:27 -0400 Received: from senator.holtmann.net ([87.106.208.187]:51867 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbYHWKC1 (ORCPT ); Sat, 23 Aug 2008 06:02:27 -0400 Subject: Re: [PATCH] ath9k: add harmlessly-omitted braces From: Marcel Holtmann To: Jim Meyering Cc: linux-kernel@vger.kernel.org, Sujith.Manoharan@atheros.com, linville@tuxdriver.com In-Reply-To: <87zln4rzce.fsf@rho.meyering.net> References: <87zln4rzce.fsf@rho.meyering.net> Content-Type: text/plain Date: Sat, 23 Aug 2008 12:02:42 +0200 Message-Id: <1219485762.7591.476.camel@violet.holtmann.net> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 487 Lines: 18 Hi Jim > Alternatively, you could remove the nowadays-useless > "if-before-kfree" test and leave the sometimes-redundant > assignment as-is: unconditional. actually the later one is preferred. Just remove the NULL check. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/