Message-ID: <48B28367.2040500@qumranet.com>
Date: Mon, 25 Aug 2008 13:03:19 +0300
From: Avi Kivity <avi@qumranet.com>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
CC: "Eric W. Biederman" <ebiederm@xmission.com>, linux-kernel@vger.kernel.org,
       kvm@vger.kernel.org
Subject: Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on	Intel
 hosts
References: <1219655506-27418-1-git-send-email-avi@qumranet.com> <20080825091508.GC9114@elte.hu> <48B27AFE.3080704@qumranet.com> <20080825093020.GA5617@elte.hu>
In-Reply-To: <20080825093020.GA5617@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1188
Lines: 38

Ingo Molnar wrote:

  

>> I'm a little worried about making emergency restart more complex.
>>
>> Another thing that worries me is that emergency_restart() doesn't 
>> reset the box -- it sends INIT.  We could do better by using the ACPI 
>> FADT reset register (hopefully that's connected to RESET).
>>     
>
> reboot was always a bit fragile - i think we should only do that if we 
> find a box where the FADT reset works better than the first-wave 
> approaches we try.
>
>   

It worked on my host.  Since it will fall back to keyboard reset and 
triple fault, it seems fairly safe.

>> Which seems to be what we want? Maybe we should just try acpi_reboot() 
>> before the other stuff.
>>     
>
> perhaps in a separate commit, for v2.6.28 at the earliest.
>   

I'll send a patch.  I don't think my earlier patch is worthwhile as all 
machines with VT are acpi capable.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/