Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756387AbYHXSE0 (ORCPT ); Sun, 24 Aug 2008 14:04:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752490AbYHXSER (ORCPT ); Sun, 24 Aug 2008 14:04:17 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:36920 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbYHXSEQ (ORCPT ); Sun, 24 Aug 2008 14:04:16 -0400 Date: Sun, 24 Aug 2008 11:03:09 -0700 (PDT) From: Linus Torvalds To: "Rafael J. Wysocki" , Vegard Nossum , Daniel J Blueman , Thomas Gleixner , Ingo Molnar cc: Linux Kernel Mailing List , Adrian Bunk , Andrew Morton , Natalie Protasevich , Kernel Testers List Subject: Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26 In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 44 On Sat, 23 Aug 2008, Rafael J. Wysocki wrote: > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11410 > Subject : SLUB list_lock vs obj_hash.lock... > Submitter : Daniel J Blueman > Date : 2008-08-22 21:48 (2 days old) > References : http://marc.info/?l=linux-kernel&m=121944176609042&w=4 This one now has a suggested patch for Daniel to try from Vegard, but no reply yet: http://marc.info/?l=linux-kernel&m=121946972307110&w=4 Vegard, I think your patch is a bit odd, though. The result of your patch is - first loop: hlist_for_each_entry_safe(obj, node, tmp, &db->list, node) { hlist_del(&obj->node); hlist_add_head(&obj->node, &freelist); } and quite frankly, I don't see what the difference between that and a something like a simple struct hlist_node *first = bd->list.first; if (first) { bd->list.first = NULL; first->pprev = &first; } really is? I dunno. We don't have list splicing ops for the hlist things. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/