Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756248AbYHXS6v (ORCPT ); Sun, 24 Aug 2008 14:58:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753044AbYHXS6n (ORCPT ); Sun, 24 Aug 2008 14:58:43 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:35321 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbYHXS6m (ORCPT ); Sun, 24 Aug 2008 14:58:42 -0400 Date: Sun, 24 Aug 2008 11:58:09 -0700 (PDT) From: Linus Torvalds To: Vegard Nossum cc: "Rafael J. Wysocki" , Daniel J Blueman , Thomas Gleixner , Ingo Molnar , Linux Kernel Mailing List , Adrian Bunk , Andrew Morton , Natalie Protasevich , Kernel Testers List Subject: Re: 2.6.27-rc4-git1: Reported regressions from 2.6.26 In-Reply-To: <19f34abd0808241143t6f5239d7o679135e9e974fe63@mail.gmail.com> Message-ID: References: <19f34abd0808241143t6f5239d7o679135e9e974fe63@mail.gmail.com> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 31 On Sun, 24 Aug 2008, Vegard Nossum wrote: > > I haven't really used the hlists before, so my first instinct was to > do what is obvious. I do agree that the hlist versions aren't very nice in this regard. The regular lists are much better at moving lists around. > Other than that, I guess open-coding list ops is also not very good > programming practice? :-) Agreed. It would be better if the people who use hlists most (I think that would be networking) would think about this. > But... feel free to submit your own patch. Oh, what am I saying. Silly boy. Next you'll ask me to _test_ any patches I send out. Anyway, I think your patch is likely fine, I just thought it looked a bit odd to have a loop to move a list from one head pointer to another. But regardless, it would need some testing. Daniel? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/