Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368AbYH0Ai6 (ORCPT ); Tue, 26 Aug 2008 20:38:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752964AbYH0Ais (ORCPT ); Tue, 26 Aug 2008 20:38:48 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:53360 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbYH0Air (ORCPT ); Tue, 26 Aug 2008 20:38:47 -0400 Date: Tue, 26 Aug 2008 17:35:24 -0700 From: sukadev@us.ibm.com To: Oleg Nesterov Cc: Andrew Morton , "Eric W. Biederman" , Pavel Emelyanov , Robert Rex , Roland McGrath , Serge Hallyn , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] pid_ns: (BUG 11391) change ->child_reaper when init->group_leader exits Message-ID: <20080827003524.GA22580@us.ibm.com> References: <20080824154912.GA3780@tv-sign.ru> <20080826233353.GA21052@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080826233353.GA21052@us.ibm.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 30 sukadev@us.ibm.com [sukadev@us.ibm.com] wrote: | I was able to repro the problem without the patchset and could not | reproduce with the patchset. But just had a quick question while | reviewing the patches. | | Oleg Nesterov [oleg@tv-sign.ru] wrote: | | We don't change pid_ns->child_reaper when the main thread of the | | subnamespace init exits. As Robert Rex | | pointed out this is wrong. | | | | Yes, the re-parenting itself works correctly, but if the reparented | | task exits it needs ->parent->nsproxy->pid_ns in do_notify_parent(), | | If the task was reparented, then with patch 1/4 its parent would be | the global init (init_pid_ns.child_reaper) right ? | | | and if the main thread is zombie its ->nsproxy was already cleared | | by exit_task_namespaces(). | | If above is true, then even if the main thread's nsproxy is NULL, does | it affect the reparented task ? never mind. I see it now. The group_dead check in current code is not sufficient (and the zap_pid_ns() may not have been called when main thread is exiting). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/