Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753690AbYH0ICR (ORCPT ); Wed, 27 Aug 2008 04:02:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752688AbYH0IB6 (ORCPT ); Wed, 27 Aug 2008 04:01:58 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:37479 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752414AbYH0IB5 (ORCPT ); Wed, 27 Aug 2008 04:01:57 -0400 Date: Wed, 27 Aug 2008 10:01:36 +0200 From: Ingo Molnar To: Steve VanDeBogart Cc: linux-kernel@vger.kernel.org, Roland McGrath , Oleg Nesterov Subject: Re: [PATCH] exit signals: use of uninitialized field notify_count Message-ID: <20080827080136.GA4453@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 20 * Steve VanDeBogart wrote: > task->signal->notify_count is only initialized if > task->signal->group_exit_task is not NULL. Reorder a conditional so > that uninitialised memory is not used. Found by Valgrind. > > Signed-off-by: Steve VanDeBogart Applied the commit below to tip/core/urgent, thanks. Roland/Oleg, do you concur with the fix? nice find btw. - are you running Valgrind on UML? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/