Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755872AbYH0JlY (ORCPT ); Wed, 27 Aug 2008 05:41:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755327AbYH0JlF (ORCPT ); Wed, 27 Aug 2008 05:41:05 -0400 Received: from wf-out-1314.google.com ([209.85.200.170]:63247 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755350AbYH0JlE (ORCPT ); Wed, 27 Aug 2008 05:41:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=WOLwE8uzDmc1r51UoGp14ka8tkj//fo2Y860TiQQ1uF3xFggaypMa99A25fOFpA8ui u2YY3Y+nVewrrk4NVgXLxf4BPsyfJWiSajjHU/KNgySNZlf2OK+rXCKlCSnQCoZgbUS7 tO9re9Jl7FksyliAmVGYjbkeT5uJzrEk0PcTk= Message-ID: Date: Wed, 27 Aug 2008 18:41:03 +0900 From: "Magnus Damm" To: "Geert Uytterhoeven" Subject: Re: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig) Cc: "Andrew Morton" , "Mauro Carvalho Chehab" , "Paul Mundt" , video4linux-list@redhat.com, "Linux Kernel Development" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080814195522.ad74990c.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1492 Lines: 37 On Wed, Aug 27, 2008 at 4:37 AM, Geert Uytterhoeven wrote: > Hi Andrew, > > On Thu, 14 Aug 2008, Andrew Morton wrote: >> ERROR: "dma_alloc_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! >> ERROR: "dma_sync_single_for_cpu" [drivers/media/video/videobuf-dma-contig.ko] undefined! >> ERROR: "dma_free_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! > > M68k allmodconfig still selects Sun-3, which sets NO_DMA. > I guess you're also seeing this on the other NO_DMA platforms (h8300, m32r, > s390, and PCI-less SPARC)? > > Below is a patch. > > Shouldn't it also (or instead) depend on SUPERH or some SuperH platform? > Or is this not done to have more compile-coverage? > > Subject: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA > > commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342): > sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced > VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the > dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG. > > Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this. Thank you! > Signed-off-by: Geert Uytterhoeven Acked-by: Magnus Damm -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/