Date: Wed, 27 Aug 2008 04:17:05 -0700 (PDT)
Message-Id: <20080827.041705.160546703.davem@davemloft.net>
To: dhowells@redhat.com
Cc: harvey.harrison@gmail.com, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] afs: fsclient.c sparse endian annotations of
 operation_ID
From: David Miller <davem@davemloft.net>
In-Reply-To: <28254.1219835544@redhat.com>
References: <1219788326.6069.40.camel@brick>
	<28254.1219835544@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 768
Lines: 20

From: David Howells <dhowells@redhat.com>
Date: Wed, 27 Aug 2008 12:12:24 +0100

> Harvey Harrison <harvey.harrison@gmail.com> wrote:
> 
> > +		if (call->operation_ID != __constant_htonl(FSFETCHDATA64)) {
> 
> Doesn't htonl() resolve to this for a constant argument?  Following through
> the definitions, it certainly looks like it ought to:

Yes it does.

The __constant_*() interfaces should only be uses for things that
must be evaluated at compile time (static data initializations,
switch statement case values etc.).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/