Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755272AbYH1Hxk (ORCPT ); Thu, 28 Aug 2008 03:53:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753157AbYH1Hxb (ORCPT ); Thu, 28 Aug 2008 03:53:31 -0400 Received: from zone0.gcu-squad.org ([212.85.147.21]:21049 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbYH1Hxa (ORCPT ); Thu, 28 Aug 2008 03:53:30 -0400 Date: Thu, 28 Aug 2008 09:53:23 +0200 From: Jean Delvare To: Seth Heasley Cc: linux-kernel@vger.kernel.org, i2c@lm-sensors.org, linux-pci@vger.kernel.org, jbarnes@virtuousgeek.org Subject: Re: [PATCH 2.6.27-rc4] i2c-i801: SMBus patch for Intel Ibex Peak DeviceIDs Message-ID: <20080828095323.58f2a60e@hyperion.delvare> In-Reply-To: <200808271652.37597.seth.heasley@intel.com> References: <200808271652.37597.seth.heasley@intel.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.10.6; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2016 Lines: 51 On Wed, 27 Aug 2008 16:52:37 -0700, Seth Heasley wrote: > This patch adds the Intel Ibex Peak (PCH) SMBus Controller DeviceIDs. > > Signed-off-by: Seth Heasley > > --- linux-2.6/drivers/i2c/busses/Kconfig.orig 2008-08-27 12:11:03.000000000 -0700 > +++ linux-2.6/drivers/i2c/busses/Kconfig 2008-08-27 12:11:24.000000000 -0700 > @@ -97,6 +97,7 @@ > ICH9 > Tolapai > ICH10 > + PCH > > This driver can also be built as a module. If so, the module > will be called i2c-i801. > --- linux-2.6/drivers/i2c/busses/i2c-i801.c.orig 2008-08-27 11:52:45.000000000 -0700 > +++ linux-2.6/drivers/i2c/busses/i2c-i801.c 2008-08-27 12:10:50.000000000 -0700 > @@ -577,6 +577,7 @@ > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TOLAPAI_1) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_4) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_5) }, > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PCH_32) }, > { 0, } > }; > > @@ -600,6 +601,7 @@ > case PCI_DEVICE_ID_INTEL_TOLAPAI_1: > case PCI_DEVICE_ID_INTEL_ICH10_4: > case PCI_DEVICE_ID_INTEL_ICH10_5: > + case PCI_DEVICE_ID_INTEL_PCH_32: > i801_features |= FEATURE_I2C_BLOCK_READ; > /* fall through */ > case PCI_DEVICE_ID_INTEL_82801DB_3: This is messy. I'm discarding this patch from my i2c tree for the time being. When things have settled on the pci_ids.h front, I'll look into applying it again. Note that your patch is still missing a chunk to Documentation/i2c/busses/i2c-i801. Originally I added it myself but if you are going to resend the same patch with different IDs every now and then, please add it on your side too, so that I don't have to fix it manually every time. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/