Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754214AbYH1KSb (ORCPT ); Thu, 28 Aug 2008 06:18:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751974AbYH1KSU (ORCPT ); Thu, 28 Aug 2008 06:18:20 -0400 Received: from postel.suug.ch ([194.88.212.233]:57573 "EHLO postel.suug.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbYH1KSU (ORCPT ); Thu, 28 Aug 2008 06:18:20 -0400 Date: Thu, 28 Aug 2008 12:18:40 +0200 From: Thomas Graf To: David Miller Cc: alexander.duyck@gmail.com, shemminger@vyatta.com, jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, alexander.h.duyck@intel.com Subject: Re: [PATCH] IPROUTE: correct nla nested message generated by netem_parse_opt Message-ID: <20080828101840.GZ20815@postel.suug.ch> References: <20080821211941.66090862@speedy> <5f2db9d90808211937o1d9b33t9ad933938872e08d@mail.gmail.com> <20080827144122.GT20815@postel.suug.ch> <20080827.234731.77434405.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080827.234731.77434405.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 16 * David Miller 2008-08-27 23:47 > It doesn't matter what "correct" compat nested attribute parsing > is or is not. The fact is that RR and PRIO were using a certain > format, consistently, prior to commit #6. This is what was > codified in userspace in the iproute2 sources and worked > correctly until #6. So we remove nla_parsed_nested_compat() just to add it again under a different name since netem is still going to use that piece of code. That certainly makes sense. Fixing prio and rr in stable is a one liner. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/