DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=Sl5NpjrLt6KsUIjHoJrC4ASCjk2ON1kD66m7IiaqWNCiDY5wy+ZzUQEujkAd8lKMdY
         8uIMECfCqFpIT84l7OJHzWHQef2+B+yBY2Goj4atIFKGY0U+VmATcvX0ORXcbBX+csBV
         SUKHLe4D5oukXOhdq6NiDqwFM1bqshPxXTs2E=
Message-ID: <a4e6962a0808281110s6ee6c86ak3ff6e28c51981656@mail.gmail.com>
Date: Thu, 28 Aug 2008 11:10:21 -0700
From: "Eric Van Hensbergen" <ericvh@gmail.com>
To: "Abhishek Kulkarni" <kulkarni@lanl.gov>
Subject: Re: [PATCH] 9p bug fix: return non-zero error value in p9_put_data
Cc: v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
In-Reply-To: <1219771831.16125.12.camel@blender>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1219771831.16125.12.camel@blender>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1454
Lines: 49

On Tue, Aug 26, 2008 at 10:30 AM, Abhishek Kulkarni <kulkarni@lanl.gov> wrote:
> p9_put_data is called by p9_create_twrite which expects it to return a
> non-zero value on error. This was the reason why every p9_client_write
> was failing. This patch also adds a check for buffer overflow in
> p9_put_data.
>

I'm a bit confused about when this is even getting called -- O thought
all writes were following the p9_client_uwrite path?

Also, we do the bufoverflow check in p9_create_write -- so with your
patch aren't we doing this twice?

           -eric


> Signed-off-by: Abhishek Kulkarni <kulkarni@lanl.gov>
> ---
>  net/9p/conv.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> diff --git a/net/9p/conv.c b/net/9p/conv.c
> index 4454720..7f6db15 100644
> --- a/net/9p/conv.c
> +++ b/net/9p/conv.c
> @@ -451,8 +451,11 @@ p9_put_data(struct cbuf *bufp, const char *data,
> int count,
>                   unsigned char **pdata)
>  {
>        *pdata = buf_alloc(bufp, count);
> +       if (buf_check_overflow(bufp))
> +               return -EIO;
> +
>        memmove(*pdata, data, count);
> -       return count;
> +       return 0;
>  }
>
>  static int
>
>
> Thanks,
>  -- Abhishek
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/