Message-ID: <48B6EF98.4070008@kernel.org>
Date: Thu, 28 Aug 2008 20:34:00 +0200
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.12 (X11/20071114)
MIME-Version: 1.0
To: Miklos Szeredi <miklos@szeredi.hu>
CC: greg@kroah.com, fuse-devel@lists.sourceforge.net,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] FUSE: implement ioctl support
References: <1219945263-21074-1-git-send-email-tj@kernel.org> <1219945263-21074-6-git-send-email-tj@kernel.org> <20080828175116.GB18461@kroah.com> <48B6E79E.6020702@kernel.org> <48B6E801.9080102@kernel.org> <E1KYm0D-0003q0-IQ@pomaz-ex.szeredi.hu> <48B6EBBD.6050406@kernel.org> <E1KYm9u-0003v5-4t@pomaz-ex.szeredi.hu>
In-Reply-To: <E1KYm9u-0003v5-4t@pomaz-ex.szeredi.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1101
Lines: 26

Miklos Szeredi wrote:
>> Hmmm... I was trying to stay within similar operation mechanics as other
>> ops.  Directly accessing the caller's memory has performance benefits
>> but that benefit can also be used by reads and writes.  So, if we're
>> gonna do direct memory access, maybe doing it in more generic way is a
>> better idea?
> 
> On the contrary: playing VM games is going to be slow.  I think this
> approach is best suited for generic ioctl support because it
> simplifies the kernel part.  I'd hate to add all that complexity to
> the kernel if not absolutely necessary.

Well, it's only 240 lines with good amount of comments and iovec copying
function.  The ioctl itself isn't too complex.  I'm a bit skeptical
about direct access.  It can easily introduce security vulnerabilities
as there really is no way to hold a pid.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/