Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758035AbYH1W14 (ORCPT ); Thu, 28 Aug 2008 18:27:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755771AbYH1W1r (ORCPT ); Thu, 28 Aug 2008 18:27:47 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:7279 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754291AbYH1W1q (ORCPT ); Thu, 28 Aug 2008 18:27:46 -0400 From: Bjorn Helgaas To: Johann Felix Soden Subject: Re: [PATCH] pci: Fix printk warnings in probe.c Date: Thu, 28 Aug 2008 16:27:41 -0600 User-Agent: KMail/1.9.9 Cc: Jesse Barnes , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yinghai Lu References: <1219430819.7010.5.camel@localhost> In-Reply-To: <1219430819.7010.5.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808281627.42171.bjorn.helgaas@hp.com> X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2616 Lines: 51 On Friday 22 August 2008 12:46:59 pm Johann Felix Soden wrote: > From: Johann Felix Soden > > Fix printk format warnings: > drivers/pci/probe.c: In function 'pci_read_bridge_bases': > drivers/pci/probe.c:386: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t' > drivers/pci/probe.c:386: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t' > drivers/pci/probe.c:398: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'resource_size_t' > drivers/pci/probe.c:398: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t' > drivers/pci/probe.c:434: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t' > drivers/pci/probe.c:434: warning: format '%llx' expects type 'long long unsigned int', but argument 5 has type 'resource_size_t' > > Signed-off-by: Johann Felix Soden > --- > drivers/pci/probe.c | 11 ++++++++--- > 1 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index cce2f4c..0ad9367 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -383,7 +383,9 @@ void __devinit pci_read_bridge_bases(struct pci_bus *child) > res->start = base; > if (!res->end) > res->end = limit + 0xfff; > - printk(KERN_INFO "PCI: bridge %s io port: [%llx, %llx]\n", pci_name(dev), res->start, res->end); > + printk(KERN_INFO "PCI: bridge %s io port: [%llx, %llx]\n", > + pci_name(dev), (unsigned long long) res->start, > + (unsigned long long) res->end); Thanks for fixing the warnings. I wish you'd changed these at the same time to use dev_info() and "[%#llx-%#llx]" like the rest of PCI. I confess I don't understand where the ioport, mmio, and prefetchable mmio resources are coming from here, but before your patch, these printed values that look like junk on an HP nw8000: PCI: bridge 0000:00:01.0 io port: [2fff00002000, ef92eae800000300] PCI: bridge 0000:00:01.0 32bit mmio: [904fffff90400000, ef92eae800000300] PCI: bridge 0000:00:01.0 32bit mmio pref: [9fffffff98000000, ef92eae8] I just returned the laptop, or I'd double-check to see whether your casts fixed this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/