Date: Thu, 28 Aug 2008 22:19:16 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
       LKML <linux-kernel@vger.kernel.org>, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] x86: early_printk.c trivial sparse fixes
Message-Id: <20080828221916.eca064ae.akpm@linux-foundation.org>
In-Reply-To: <1219103789.17033.0.camel@brick>
References: <1219103789.17033.0.camel@brick>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 952
Lines: 27

On Mon, 18 Aug 2008 16:56:29 -0700 Harvey Harrison <harvey.harrison@gmail.com> wrote:

> --- a/arch/x86/kernel/early_printk.c
> +++ b/arch/x86/kernel/early_printk.c
> @@ -989,7 +989,7 @@ static int __init setup_early_printk(char *buf)
>  	return 0;
>  }
>  
> -void __init enable_debug_console(char *buf)
> +static void __init enable_debug_console(char *buf)
>  {
>  #ifdef DBGP_DEBUG
>  	struct console *old_early_console = NULL;

umm,

arch/x86/kernel/early_printk.c:993: warning: 'enable_debug_console' defined but not used

enable_debug_console() never has been used afaict.  If it was supposed
to be a __setup function then it'll need documentation in
Documentation/kernel-parameters.txt too, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/