Date: Fri, 29 Aug 2008 01:48:09 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
       Hugh Dickins <hugh@veritas.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: hugetlb.c make functions static, use NULL rather
 than 0
Message-Id: <20080829014809.be6689f6.akpm@linux-foundation.org>
In-Reply-To: <20080829082950.GC3387@brain>
References: <1219445274.4493.10.camel@brick>
	<Pine.LNX.4.64.0808251023220.8672@blonde.site>
	<20080829082950.GC3387@brain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1001
Lines: 20

On Fri, 29 Aug 2008 09:29:50 +0100 Andy Whitcroft <apw@shadowen.org> wrote:

> On Mon, Aug 25, 2008 at 10:27:39AM +0100, Hugh Dickins wrote:
> > On Fri, 22 Aug 2008, Harvey Harrison wrote:
> > 
> > > mm/hugetlb.c:265:17: warning: symbol 'resv_map_alloc' was not declared. Should it be static?
> > > mm/hugetlb.c:277:6: warning: symbol 'resv_map_release' was not declared. Should it be static?
> > > mm/hugetlb.c:292:9: warning: Using plain integer as NULL pointer
> > > mm/hugetlb.c:1750:5: warning: symbol 'unmap_ref_private' was not declared. Should it be static?
> 
> Harvey are you using some additional compiler flags to get this, I am
> pretty sure I checked for warnings during compilation before this lot
> was merged.  Hmmm.

sparse.   `make C=1'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/