From: Arnd Bergmann <arnd@arndb.de>
To: leoli@freescale.com
Subject: Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver
Date: Fri, 29 Aug 2008 10:57:20 +0200
User-Agent: KMail/1.9.9
Cc: linuxppc-dev@ozlabs.org, greg@kroah.com, linux-usb@vger.kernel.org,
       dbrownell@users.sourceforge.net, linux-kernel@vger.kernel.org
References: <1219916613-28827-1-git-send-email-leoli@freescale.com> <200808281704.20999.arnd@arndb.de> <1220000265.30607.10.camel@Gundam>
In-Reply-To: <1220000265.30607.10.camel@Gundam>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200808291057.20612.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 989
Lines: 23

On Friday 29 August 2008, Li Yang wrote:
> 
> > Not a problem, but an observation: Most new code uses work queues instead
> > of tasklets these days, which gives you more predictable real time
> > latencies.
> > If you don't have a specific reason to prefer a tasklet, just use
> > a workqueue here.
> 
> Is this truly a trend? ?Work queue is more flexible but it has higher
> latency. ?Why are work queues preferred?

Most drivers don't need the low irq to bottom half latency. As I said,
not a problem at all, just my observation. In 2.6.27, we have around
three times more new workqueue usages than new tasklet usages. My
feeling from doing reviews was that it would be closer to a factor
of ten, but I guess I was wrong in that.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/