Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757883AbYH2VMn (ORCPT ); Fri, 29 Aug 2008 17:12:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755708AbYH2VMd (ORCPT ); Fri, 29 Aug 2008 17:12:33 -0400 Received: from nebensachen.de ([195.34.83.29]:58172 "EHLO mail.nebensachen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755100AbYH2VMc (ORCPT ); Fri, 29 Aug 2008 17:12:32 -0400 X-Hashcash: 1:20:080829:alan@lxorguk.ukuu.org.uk::flIWTf8xnT83TK3Y:00000000000000000000000000000000000003xfK X-Hashcash: 1:20:080829:akpm@linux-foundation.org::a1PUKzvfb+7wii4W:0000000000000000000000000000000000009pVc X-Hashcash: 1:20:080829:bzolnier@gmail.com::kvtCGZd8xG48ODis:00000000000000000000000000000000000000000003KYB X-Hashcash: 1:20:080829:jeff@garzik.org::veIRZc2Ij85mJgGT:0044Nn X-Hashcash: 1:20:080829:randy.dunlap@oracle.com::AEavYVumMrvVqYif:000000000000000000000000000000000000001ZrZ X-Hashcash: 1:20:080829:htejun@gmail.com::bSftDfohjWaFiuA7:04WTw X-Hashcash: 1:20:080829:linux-ide@vger.kernel.org::Qhw5me7kBN/rBOa3:0000000000000000000000000000000000003GuB X-Hashcash: 1:20:080829:linux-kernel@vger.kernel.org::h0JrWVfjwIW+e/pZ:0000000000000000000000000000000001ps+ From: Elias Oltmanns To: Alan Cox , Andrew Morton , Bartlomiej Zolnierkiewicz , Jeff Garzik , Randy Dunlap , Tejun Heo Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC] Disk shock protection in GNU/Linux (take 2) Date: Fri, 29 Aug 2008 23:11:27 +0200 Message-ID: <87wshzplvk.fsf@denkblock.local> User-Agent: Gnus/5.110007 (No Gnus v0.7) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2111 Lines: 47 [ Resending with correct address for lkml, sorry. ] Hi all, this is the second version of the patch series I posted a month ago. There are the following changes: - ata_id_has_unload() checks for the major version of the ATA spec the drive claims to comply with. - A disk head unload request issued to a device will effectively cause the same to be executed for all devices on the same port and stop all I/O to that port. Tejun told me that modern CD/DVD writers should have no difficulties to recover from buffer under-runs caused by such a behaviour (I haven't had a chance to put it to the test). - As for the part dealing with libata, I have been following Tejun's advice to rely on EH for the purposes of serialisation and in order to prevent spurious resets. Hopefully, this has turned out satisfactorily. As a nice side effect I don't have to touch any scsi stuff at all due to this approach. - Various minor changes intended to optimise the code or simply to make more compliant with kernel coding conventions. Unless there are any immediate objections from anyone, could the subsystem maintainers please voice their opinion whether these patches are likely to make it into 2.6.28? For obvious reasons, I'd like to make sure that the changes to libata and ide are introduced at the same time even though they don't depend on each other technically. Does that make the patch set a candidate for the mm tree, or should the patches go through the libata and ide tree respectively? Here are the short descriptions of the four patches (based on next-20080829): 1. This is a small patch to ata.h in order to provide a simple check for support of the unload feature as indicated in a device's ID. 2. Here disk head unloading is implemented in the libata subsystem. 3. The same for ide. 4. A little bit of documentation. Regards, Elias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/