Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758033AbYH3D0T (ORCPT ); Fri, 29 Aug 2008 23:26:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754578AbYH3D0G (ORCPT ); Fri, 29 Aug 2008 23:26:06 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39381 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040AbYH3D0E (ORCPT ); Fri, 29 Aug 2008 23:26:04 -0400 Date: Fri, 29 Aug 2008 20:24:52 -0700 (PDT) From: Linus Torvalds To: Yinghai Lu cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Jeff Garzik , Tejun Heo , Ingo Molnar , David Witbrodt , Andrew Morton , Kernel Testers Subject: Re: Linux 2.6.27-rc5: System boot regression caused by commit a2bd7274b47124d2fc4dfdb8c0591f545ba749dd In-Reply-To: <86802c440808292007t3588edfnef95b723320ff023@mail.gmail.com> Message-ID: References: <200808300031.16708.rjw@sisk.pl> <86802c440808291624t2bd0229w2da36dfc6c794b18@mail.gmail.com> <86802c440808291711t32d3e76dsf804856b0a8f4939@mail.gmail.com> <86802c440808291830t4547140dx9b12353649edd975@mail.gmail.com> <86802c440808292007t3588edfnef95b723320ff023@mail.gmail.com> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 30 On Fri, 29 Aug 2008, Yinghai Lu wrote: > > we need to use insert_resource_split_to_fit instead... > > otherwise __request_region will not be happy. Are you really really sure? Try just removing the IORESOURCE_BUSY. As mentioned, if we expect the PCI BAR's to work with the e820 resources, then BUSY really is simply not right any more. Not that I think it should matter either.. The ones that are added _early_ should be IORESOURCE_BUSY (ie the ones that cover RAM), but the others we now expect to nest with PCI BARs. But since we add them after we have parsed the BAR's, I don't even see why the BUSY bit should even matter - we've already added the fixed BARs, and any newly allocated non-fixed ones shouldn't be allocated in e820 areas _regardless_ of whether the BUSY bit is set or not. So pls explain why it matters? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/