Date: Sat, 30 Aug 2008 23:52:26 +0900 (JST)
Message-Id: <20080830.235226.108118828.anemo@mba.ocn.ne.jp>
To: david@fries.net
Cc: linux-kernel@vger.kernel.org, p_gortmaker@yahoo.com, netdev@vger.kerne.org
Subject: Re: [PATCH] ne.c fix for hibernate and rmmod oops fix
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <20080830022749.GF17528@spacedout.fries.net>
References: <20080828041110.GA9404@spacedout.fries.net>
	<20080830.002215.128620618.anemo@mba.ocn.ne.jp>
	<20080830022749.GF17528@spacedout.fries.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 977
Lines: 26

On Fri, 29 Aug 2008 21:27:49 -0500, David Fries <david@fries.net> wrote:
> > With your patch, cleanup_module() and ne_exit() is exactly same.  How
> > about unifying them?
> 
> They didn't use to be the same, with all the cleanup I didn't notice
> that they became the same.  ne_exit is no more, cleanup_module for
> both module and built in.

The name "cleanup_module" is special.  I think this should not be used
outside #ifdef MODULE.  Please rename it something like
ne_cleanup_module() and make it static.  Or just use ne_exit().

> > This .name initialization seems a bit redundant for me.  They can be
> > left NULL.
> 
> Changed.

Thanks.  You killed two .name and there are still two .name in ne_probe.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/