Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754534AbYHaRPW (ORCPT ); Sun, 31 Aug 2008 13:15:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753417AbYHaRPG (ORCPT ); Sun, 31 Aug 2008 13:15:06 -0400 Received: from mba.ocn.ne.jp ([122.1.235.107]:55939 "EHLO smtp.mba.ocn.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753528AbYHaRPF (ORCPT ); Sun, 31 Aug 2008 13:15:05 -0400 Date: Mon, 01 Sep 2008 02:15:05 +0900 (JST) Message-Id: <20080901.021505.108307990.anemo@mba.ocn.ne.jp> To: david@fries.net Cc: linux-kernel@vger.kernel.org, p_gortmaker@yahoo.com, netdev@vger.kernel.org Subject: Re: [PATCH 1/2] ne.c fix, res->name From: Atsushi Nemoto In-Reply-To: <20080830180503.GI25161@spacedout.fries.net> References: <20080830024425.GA24929@spacedout.fries.net> <20080831.000357.70223885.anemo@mba.ocn.ne.jp> <20080830180503.GI25161@spacedout.fries.net> X-Fingerprint: 6ACA 1623 39BD 9A94 9B1A B746 CA77 FE94 2874 D52F X-Pgp-Public-Key: http://wwwkeys.pgp.net/pks/lookup?op=get&search=0x2874D52F X-Mailer: Mew version 5.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 827 Lines: 24 On Sat, 30 Aug 2008 13:05:03 -0500, David Fries wrote: > On Sun, Aug 31, 2008 at 12:03:57AM +0900, Atsushi Nemoto wrote: > > On Fri, 29 Aug 2008 21:44:25 -0500, David Fries wrote: > > > + if (!strcmp(res->name, BAD_STR)) > > > + dev->mem_end = BAD; > > > > The res->name might be NULL. You should check it first. > > > > if (res->name && !strcmp(res->name, BAD_STR)) > > dev->mem_end = BAD; > > The name gets a valid string by that point in time. > > drivers/base/platform.c:257 Oh, you are right. Sorry for noise. --- Atsushi Nemoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/