Date: Wed, 1 Oct 2008 10:35:32 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Steven Noonan <steven@uplinklabs.net>
Cc: linux-kernel@vger.kernel.org, drzeus@drzeus.cx
Subject: Re: [PATCH -tip] sdhci: 'scratch' may be used uninitialized
Message-ID: <20081001083532.GE31009@elte.hu>
References: <20081001080048.GB25832@elte.hu> <1222848842-10798-1-git-send-email-steven@uplinklabs.net> <f488382f0810010133j50f70705w59f207434a6b025e@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f488382f0810010133j50f70705w59f207434a6b025e@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1212
Lines: 28


* Steven Noonan <steven@uplinklabs.net> wrote:

> On Wed, Oct 1, 2008 at 1:14 AM, Steven Noonan <steven@uplinklabs.net> wrote:
> > -       u32 scratch;
> > +       u32 uninitialized_var(scratch);
> 
> A bit of a further explanation:
> 
> The variable 'scratch' is always initialized before it's used. The
> conditional which is responsible for initialization of 'scratch' will
> always evaluate 'true' when the first loop iteration occurs, and thus,
> it's properly initialized. GCC doesn't see this, of course, so using
> the uninitialized_var() macro seems to work for silencing this case.

another small workflow suggestion: when you add explanation for the 
changelog it's better to just include the updated patch (dont worry 
about the duplication) - that way maintainers dont have to cut&slice the 
patch and the description toghether. [which is not just a matter of 
wasting time, but if you do tons of patch juggling, it becomes a real 
risk factor.]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/