Date: Wed, 01 Oct 2008 10:56:32 +0200
Message-ID: <s5hej30g0cf.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Noonan <steven@uplinklabs.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -tip] pcm_native: label out defined but not used
In-Reply-To: <20081001083224.GC31009@elte.hu>
References: <1222847847-7127-1-git-send-email-steven@uplinklabs.net>
	<20081001075921.GA25832@elte.hu>
	<s5h63ocd96s.wl%tiwai@suse.de>
	<20081001083224.GC31009@elte.hu>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 964
Lines: 38

At Wed, 1 Oct 2008 10:32:24 +0200,
Ingo Molnar wrote:
> 
> 
> * Takashi Iwai <tiwai@suse.de> wrote:
> 
> > At Wed, 1 Oct 2008 09:59:21 +0200,
> > Ingo Molnar wrote:
> > > 
> > > 
> > > (Cc:-ed Taskashi for this ALSA cleanup patch.)
> > 
> > This label is used when the debug option is enabled.
> 
> ah, indeed:
> 
>         snd_assert(substream != NULL, goto out);
> 
> if then i'd suggest to clean it up like this:
> 
>         if (snd_assert(substream != NULL))
> 		goto out;
> 
> this is how DEBUG_LOCKS_WARN_ON() is used in kernel/lockdep.c for 
> example. Putting code flow side-effects into debug macros looks a bit 
> weird.

Yeah, already a similar change was done in the latest ALSA tree :)


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/