Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbYJAKer (ORCPT ); Wed, 1 Oct 2008 06:34:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753556AbYJAKeb (ORCPT ); Wed, 1 Oct 2008 06:34:31 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:46206 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753521AbYJAKea (ORCPT ); Wed, 1 Oct 2008 06:34:30 -0400 Date: Wed, 1 Oct 2008 11:34:18 +0100 From: Alan Cox To: Steven Noonan Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, Steven Noonan Subject: Re: [PATCH -tip] drivers/serial/8250.c: 'i' may be used uninitialized Message-ID: <20081001113418.1b23ccb7@lxorguk.ukuu.org.uk> In-Reply-To: <1222849017-10896-1-git-send-email-steven@uplinklabs.net> References: <20081001080150.GC25832@elte.hu> <1222849017-10896-1-git-send-email-steven@uplinklabs.net> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.12; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 15 On Wed, 1 Oct 2008 01:16:57 -0700 Steven Noonan wrote: > Signed-off-by: Steven Noonan I'd rather have the warning than that particular ugly in the source of the serial/tty code. It doesn't fit the pattern of attributes used elsewhere in the code (__unused __user etc). Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/