DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=yCe44IqBYmovIH0Icbtbsxk6byeavslZHWIRqyQx/O7JI961FdvUGIe8yT6hFoB7amFeISUEmhkexWrSmCGhKoSdUuJA3GDoKOrh508lHQoT/Fdt4eF2Ji2zcBf1q3Xghcseemcrw90JmVq24rpk2Nak6qHK6JTnzDuONzDXqeg=  ;
From: David Brownell <david-b@pacbell.net>
To: Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH 2.6.27-rc8 1/2] drivers/mfd/twl4030-core.c
Date: Wed, 1 Oct 2008 13:19:25 -0700
User-Agent: KMail/1.9.9
Cc: Samuel Ortiz <sameo@openedhand.com>, lkml <linux-kernel@vger.kernel.org>,
       Tony Lindgren <tony@atomide.com>, Felipe Balbi <felipe.balbi@nokia.com>,
       linux-omap@vger.kernel.org, Mikko Ylinen <mikko.k.ylinen@nokia.com>
References: <200810011144.20510.david-b@pacbell.net> <20081001124407.aa090ccd.randy.dunlap@oracle.com>
In-Reply-To: <20081001124407.aa090ccd.randy.dunlap@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200810011319.26780.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1280
Lines: 42

On Wednesday 01 October 2008, Randy Dunlap wrote:

> > +	  These multi-function chps are found on many OMAP2 and OMAP3
> 
> 	                       chips

Indeed ... although if e e cummings could write poetry without
uppercase, surely in this modern age some literature will be
forthcoming that uses no vwls?  (Oh wait.  That's Hebrew.  ;)


> > --- /dev/null
> > +++ b/include/linux/i2c/twl4030-madc.h
> > @@ -0,0 +1,134 @@
> > +/*
> > + * include/linux/i2c/twl4030-madc.h
> > + *
> > + * TWL4030 MADC module driver header
> > + *
> > + * Copyright (C) 2008 Nokia Corporation
> > + * Mikko Ylinen <mikko.k.ylinen@nokia.com>
> 
> 
> > +#define TWL4030_MADC_IOC_MAGIC '`'
> 
> Add that to Documentation/ioctl-number.txt (?)

Actually one of my own review comments is that this header
should become unneccessary ... and everything associated
with it be dealt with when this Multi-channel ADC driver
gets pushed upstream.  IRQ initialization needs to be done
in the core, but none of the other MADC stuff matters here.

Thanks.


- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/